Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed reviews count data format #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sksshouvo
Copy link

No description provided.

@amineboutarfi
Copy link
Owner

@sksshouvo I don't understand why you want reviews_count to be a String and not an Integer? Can you please explain why you want to do the change? Also for this to work, you also need to change the datatype in the Business dataclass (we have: reviews_count: int = None)

@sksshouvo
Copy link
Author

@sksshouvo I don't understand why you want reviews_count to be a String and not an Integer? Can you please explain why you want to do the change? Also for this to work, you also need to change the datatype in the Business dataclass (we have: reviews_count: int = None)

@amineboutarfi Because when I run the Python script, playwright opens up google chromium with my native language "Bengali" and the number are also in bengla so it returns error.

@amineboutarfi
Copy link
Owner

@sksshouvo makes sense yes. Please update the dataclasee in your PR to also change:
reviews_count: int = None -> reviews_count: str = None

Also don't include CSVs and xlsx in your PR if possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants